Skip to content

Commit

Permalink
Make form listener work without decorating shopware form listener
Browse files Browse the repository at this point in the history
  • Loading branch information
shyim committed Sep 12, 2017
1 parent 0186b88 commit 545af60
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 15 deletions.
13 changes: 1 addition & 12 deletions Components/FormListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

namespace ShyimProfiler\Components;


use Shopware\Bundle\FormBundle\Extension\EventExtension;
use Symfony\Component\Form\AbstractTypeExtension;
use Symfony\Component\Form\Extension\DataCollector\FormDataCollectorInterface;
use Symfony\Component\Form\FormBuilderInterface;
Expand All @@ -13,12 +11,6 @@

class FormListener extends AbstractTypeExtension
{
/**
* @var EventExtension
* @author Soner Sayakci <[email protected]>
*/
private $eventExtension;

/**
* @var FormDataCollectorInterface
* @author Soner Sayakci <[email protected]>
Expand All @@ -27,13 +19,11 @@ class FormListener extends AbstractTypeExtension

/**
* FormListener constructor.
* @param EventExtension $eventExtension
* @param FormDataCollectorInterface $formDataCollector
* @author Soner Sayakci <[email protected]>
*/
public function __construct(EventExtension $eventExtension, FormDataCollectorInterface $formDataCollector)
public function __construct(FormDataCollectorInterface $formDataCollector)
{
$this->eventExtension = $eventExtension;
$this->dataCollector = $formDataCollector;
}

Expand All @@ -47,7 +37,6 @@ public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder->addEventListener(FormEvents::POST_SET_DATA, [$this, 'postSetData'], 255);
$builder->addEventListener(FormEvents::POST_SUBMIT, [$this, 'postSubmit'], -255);
$this->eventExtension->buildForm($builder, $options);
}


Expand Down
4 changes: 2 additions & 2 deletions Resources/services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@
<argument type="service" id="shyim_profiler.forms.data_extractor"/>
</service>

<service id="shyim_profiler.forms.form_listener" class="ShyimProfiler\Components\FormListener" decorates="shopware.form.extension.event">
<argument type="service" id="shyim_profiler.forms.form_listener.inner"/>
<service id="shyim_profiler.forms.form_listener" class="ShyimProfiler\Components\FormListener">
<argument type="service" id="shyim_profiler.forms.data_collector"/>
<tag name="form.type_extension" extended-type="Symfony\Component\Form\Extension\Core\Type\FormType" />
</service>
</services>
</container>
2 changes: 1 addition & 1 deletion Resources/views/frontend/profiler/detail.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

{block name="content"}
<div id="summary">
<div class="status {if $sDetail.response.httpResponse == 200}status-success{else}status-error{/if}">
<div class="status {if $sDetail.response.httpResponse == 200 || $sDetail.response.httpResponse == 302}status-success{else}status-error{/if}">
<div class="container">
<h2 class="break-long-words">
<a href="{$sDetail.request.url}">{$sDetail.request.url}</a>
Expand Down

0 comments on commit 545af60

Please sign in to comment.