Add more tests

FriendsOfCake · Oct 8, 2018 · 10fa0d5 · 10fa0d5
1 parent 07d634f
commit 10fa0d5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/Model/Filter/Base.php b/src/Model/Filter/Base.php
@@ -214,7 +214,7 @@ protected function passedValue()
             return $this->getConfig('multiValue') ? $value : null;
         }
 
-        if ($this->getConfig('multiValue') && $this->getConfig('multiValueSeparator')) {
+        if ($this->getConfig('multiValueSeparator')) {
             return explode($this->getConfig('multiValueSeparator'), $value);
         }
 

diff --git a/tests/TestCase/Model/Filter/BaseTest.php b/tests/TestCase/Model/Filter/BaseTest.php
@@ -201,14 +201,27 @@ public function testValueMultiValueSeparator()
             ['defaultValue' => 'default']
         );
 
-        $filter->setConfig('multiValue', true);
         $filter->setConfig('multiValueSeparator', '|');
 
         $filter->setArgs(['field' => 'value1|value2']);
         $this->assertEquals(['value1', 'value2'], $filter->value());
+    }
 
-        $filter->setArgs(['field' => ['value1', 'value2']]);
-        $this->assertEquals(['value1', 'value2'], $filter->value());
+    /**
+     * @return void
+     */
+    public function testValueMultiValueSeparatorInvalid()
+    {
+        $filter = new TestFilter(
+            'field',
+            $this->Manager,
+            ['defaultValue' => 'default']
+        );
+
+        $filter->setConfig('multiValue', true);
+
+        $filter->setArgs(['field' => 'value1|value2']);
+        $this->assertEquals('value1|value2', $filter->value());
     }
 
     /**