Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add radius param of 10 #732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add radius param of 10 #732

wants to merge 2 commits into from

Conversation

arne182
Copy link
Contributor

@arne182 arne182 commented Jan 25, 2025

@arne182
Add radius param of 10
e5ee296 
Freika#652
@arne182
Fix reverse geocoding issue
908232d 
Previously, reverse geocoding queries in the Photon lookup did not properly
limit results within a specified search radius, leading to inaccurate or
unexpected locations being returned. This fix ensures that the :radius
parameter is passed directly, just like :limit and :distance_sort, instead
of being nested under :params.
By aligning with the Photon lookup implementation in Geocoder, this change
improves accuracy and ensures that results are correctly filtered based on
proximity, resolving issues where points were incorrectly matched due to
missing radius constraints.

Resolves: Reverse geocoding mismatch for close proximity queries
@narucx
Copy link

narucx commented Jan 27, 2025

I wouldnt set it as default only if the first run failed to find data as radius=10 sets a radius of 10km which could change a lot

@arne182
Copy link
Contributor Author

arne182 commented Jan 27, 2025

it seams to snap to the closest, so no change if set to 2, 10 or 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arne182 @narucx