add Sentry error

clean up css and components from unnecessary class
Freegle · Oct 24, 2023 · f42bfe4 · f42bfe4
1 parent b3a5fcd
commit f42bfe4
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 20 deletions.
diff --git a/assets/css/global.scss b/assets/css/global.scss
@@ -533,11 +533,3 @@ label {
     font-size: 1.8rem;
   }
 }
-
-.modal-above-fade {
-  // We can't get this quite how we'd like.  We'd like these ads to appear above the modal fade, and below the modal content.
-  // But we can't do that, because of the way that position: fixed locks the z-index of the children.  That means the
-  // effective z-index of the fade and the modal contents is the same.  So we do this, which will occasionally overlap
-  // the modal contents in an annoying way.  It would be nice to figure out something better.
-  //z-index: 1056 !important;
-}
diff --git a/components/ExternalDa.vue b/components/ExternalDa.vue
@@ -24,6 +24,7 @@
   </div>
 </template>
 <script setup>
+import * as Sentry from '@sentry/vue';
 import { nextTick } from 'vue'
 import { useMiscStore } from '../stores/misc'
 import { ref, computed, onBeforeUnmount } from '#imports'
@@ -136,12 +137,9 @@ async function visibilityChanged(visible) {
               }, 45000)
             }
           }).addEventListener("slotVisibilityChanged", (event) => {
-            const slot = event.slot;
-            console.group("Visibility of slot", slot.getSlotElementId(), "changed.");
-
-            // Log details of the event.
-            console.log("Visible area:", `${event.inViewPercentage}%`);
-            console.groupEnd();
+            if (event.inViewPercentage < 51) {
+              Sentry.captureMessage(`Visibility of slot ${event.slot.getSlotElementId()} changed. New visibility: ${event.inViewPercentage}%.Viewport size: ${window.innerWidth}x${window.innerHeight}`);
+            }
           });
 
         window.googletag.enableServices()

diff --git a/pages/browse/[[term]].vue b/pages/browse/[[term]].vue
@@ -6,7 +6,7 @@
         <b-col cols="0" lg="3" class="p-0 pr-1">
           <VisibleWhen
             :not="['xs', 'sm', 'md', 'lg']"
-            class="position-fixed modal-above-fade"
+            class="position-fixed"
             style="width: 300px"
           >
             <ExternalDa
@@ -111,7 +111,7 @@
           <div class="d-flex justify-content-end">
             <VisibleWhen
               :not="['xs', 'sm', 'md', 'lg']"
-              class="position-fixed modal-above-fade"
+              class="position-fixed"
               style="right: 5px"
             >
               <ExternalDa

diff --git a/pages/message/[id].vue b/pages/message/[id].vue
@@ -6,7 +6,7 @@
         <b-col cols="0" xl="3" class="d-none d-xl-block">
           <VisibleWhen
             :not="['xs', 'sm', 'md', 'lg']"
-            class="position-fixed modal-above-fade"
+            class="position-fixed"
             style="width: 300px"
           >
             <ExternalDa
@@ -96,7 +96,7 @@
         <b-col cols="0" xl="3" class="d-none d-xl-block">
           <VisibleWhen
             :not="['xs', 'sm', 'md', 'lg']"
-            class="position-fixed modal-above-fade"
+            class="position-fixed"
             style="width: 300px"
           >
             <ExternalDa

diff --git a/pages/myposts.vue b/pages/myposts.vue
@@ -11,7 +11,7 @@
         <b-col cols="0" lg="3" class="p-0 pr-1">
           <VisibleWhen
             :not="['xs', 'sm', 'md', 'lg']"
-            class="position-fixed modal-above-fade"
+            class="position-fixed"
             style="width: 300px"
           >
             <ExternalDa
@@ -67,7 +67,7 @@
         <b-col cols="0" lg="3" class="p-0 pl-1">
           <VisibleWhen
             :not="['xs', 'sm', 'md', 'lg']"
-            class="position-fixed modal-above-fade"
+            class="position-fixed"
             style="right: 5px"
           >
             <ExternalDa