PR feedback

Freegle · Dec 21, 2023 · 95b48ad · 95b48ad
1 parent 4a50b6d
commit 95b48ad
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/components/DraggableMap.vue b/components/DraggableMap.vue
@@ -114,27 +114,30 @@ export default {
           navigator.geolocation &&
           navigator.geolocation.getCurrentPosition
         ) {
-          this.locating = true
           navigator.geolocation.getCurrentPosition(
             (position) => {
               // Show close to where we think they are.
-              this.locating = false
               this.mapObject.flyTo(
                 [position.coords.latitude, position.coords.longitude],
                 16
               )
+              callback()
             },
-            () => (this.locating = false)
+            () => {
+              this.locationFailed = true
+              callback()
+            }
           )
         } else {
           console.log('Navigation not supported.  ')
           this.locationFailed = true
+          callback()
         }
       } catch (e) {
         console.error('Find location failed with', e)
         this.locationFailed = true
+        callback()
       }
-      callback()
     },
     idle() {
       this.center = this.mapObject.getCenter()

diff --git a/components/SpinButton.vue b/components/SpinButton.vue
@@ -24,15 +24,11 @@
       <slot>{{ label }}</slot>
     </span>
   </b-button>
-  <client-only>
-    <teleport to="body">
-      <ConfirmModal
-        v-if="confirm && showConfirm"
-        @confirm="confirmed"
-        @hidden="onConfirmClosed"
-      />
-    </teleport>
-  </client-only>
+  <ConfirmModal
+    v-if="confirm && showConfirm"
+    @confirm="confirmed"
+    @hidden="onConfirmClosed"
+  />
 </template>
 <script setup>
 import { ref } from '#imports'