Use short posts and comments IDs in the URLs #1639
Conversation
|
♻️ PR Preview 4bff3e4 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
src/utils/parse-text.js
Outdated
| const beforeChars = new RegExp(`[${wordAdjacentChars}]`); | ||
| const afterChars = new RegExp(`[${wordAdjacentChars.clone().removeChars('/')}]`); |
There was a problem hiding this comment.
I think //clbn/a0f76b should NOT be hyperlinked the same way /clbn/a0f76b/ isn't. (So I would add removeChars('/') to beforeChars as well.)
There was a problem hiding this comment.
Well, it will be linked as /[/clbn/a0f76b], which isn't too bad... Maybe there are some specific cases in which this can lead to incorrect results?
There was a problem hiding this comment.
My point is that the default behavior should be to not link text unless we are sure the user's intention is to have a link. And since I can't come up with any legitimate case for having a slash in front of a link, we shouldn't link it the same way we don't link /clbn/a0f76b/.
This is the client-side part of the Short Links feature.
Added
/user/4a39b8(a post) or/groupname/f482e5#ad2b(a comment)./user/...) are now parses in texts as active links.