-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Adding CI/CD Workflows and Scripts #40
Chore: Adding CI/CD Workflows and Scripts #40
Conversation
@DhairyaMajmudar is attempting to deploy a commit to the francescoxx's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes encompass the addition of GitHub Actions workflows for issue labeling, pull request handling, and stale issue management. Also included are updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Hi @FrancescoXX pls. once have a look into these : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- .github/workflows/issue-labeler.yml (1 hunks)
- .github/workflows/pull-request.yml (1 hunks)
- .github/workflows/stale.yml (1 hunks)
- package.json (1 hunks)
- src/app/globals.css (1 hunks)
- src/app/page.tsx (2 hunks)
- src/components/Footer.tsx (1 hunks)
- src/components/GitHubStars.tsx (3 hunks)
- src/components/Header.tsx (1 hunks)
- src/components/SubstackEmbed.tsx (1 hunks)
- tailwind.config.ts (1 hunks)
Files skipped from review due to trivial changes (8)
- .github/workflows/issue-labeler.yml
- .github/workflows/stale.yml
- src/app/globals.css
- src/components/Footer.tsx
- src/components/GitHubStars.tsx
- src/components/Header.tsx
- src/components/SubstackEmbed.tsx
- tailwind.config.ts
Additional comments not posted (29)
package.json (5)
9-9
: LGTM!The
lint
script is correctly configured to run the linting process using Next.js.
10-10
: LGTM!The
ts
script is correctly configured to run TypeScript compilation without emitting output files.
11-11
: LGTM!The
typecheck
script is correctly configured to run TypeScript compilation with pretty output without emitting output files.
12-12
: LGTM!The
format:fix
script is correctly configured to run Prettier to fix formatting issues in TypeScript, JSON, and CSS files.
13-13
: LGTM!The
format:check
script is correctly configured to run Prettier to check for formatting issues in TypeScript and CSS files.src/app/page.tsx (10)
1-1
: LGTM!The import statement for
Header
uses double quotes, which is consistent with the project's coding standards.
2-2
: LGTM!The import statement for
Footer
uses double quotes, which is consistent with the project's coding standards.
3-3
: LGTM!The import statement for
Image
uses double quotes, which is consistent with the project's coding standards.
4-4
: LGTM!The import statement for
GitHubStars
uses double quotes, which is consistent with the project's coding standards.
5-5
: LGTM!The import statement for
SubstackEmbed
uses double quotes, which is consistent with the project's coding standards.
14-18
: LGTM!The anchor tag attributes use double quotes, which is consistent with the project's coding standards.
21-26
: LGTM!The
Image
component attributes use double quotes, which is consistent with the project's coding standards.
32-34
: LGTM!The paragraph tag attributes use double quotes, which is consistent with the project's coding standards.
32-34
: LGTM!The paragraph tag attributes use double quotes, which is consistent with the project's coding standards.
32-34
: LGTM!The
SubstackEmbed
component is embedded with a comment, which is consistent with the project's coding standards..github/workflows/pull-request.yml (14)
11-12
: LGTM!The step is correctly configured to check out the repository using
actions/checkout@v4
.
14-16
: LGTM!The step is correctly configured to set the yarn cache directory path.
18-26
: LGTM!The step is correctly configured to cache Node dependencies using
actions/cache@v4
.
27-30
: LGTM!The step is correctly configured to list the state of node modules if the cache is not hit.
32-35
: LGTM!The step is correctly configured to set up Node.js using
actions/setup-node@v4
.
37-38
: LGTM!The step is correctly configured to install dependencies using
yarn install --frozen-lockfile
.
40-41
: LGTM!The step is correctly configured to run linting and formatting checks using
yarn run lint
.
43-44
: LGTM!The step is correctly configured to run type checking using
yarn run typecheck
.
51-54
: LGTM!The step is correctly configured to check out the repository with submodules using
actions/checkout@v4
.
56-58
: LGTM!The step is correctly configured to set the yarn cache directory path.
60-68
: LGTM!The step is correctly configured to cache Node dependencies using
actions/cache@v4
.
69-72
: LGTM!The step is correctly configured to list the state of node modules if the cache is not hit.
74-83
: LGTM!The step is correctly configured to cache the Next.js build using
actions/cache@v4
.
84-87
: LGTM!The step is correctly configured to set up Node.js using
actions/setup-node@v4
.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This branch has conflicts, can you check them? thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- package.json (1 hunks)
- src/app/page.tsx (1 hunks)
- src/components/Footer.tsx (2 hunks)
- src/components/GitHubStars.tsx (2 hunks)
- src/components/SubstackEmbed.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- package.json
- src/components/Footer.tsx
- src/components/GitHubStars.tsx
- src/components/SubstackEmbed.tsx
Additional comments not posted (1)
src/app/page.tsx (1)
8-8
: LGTM!The addition of an empty line improves readability by separating the imports from the component definition.
I have removed the conflicts : ) |
thank you. btw we should proceed with issues first. I don't want the whole workflow to start failing and it's hard to test out without merging it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- package.json (1 hunks)
- src/app/page.tsx (1 hunks)
- src/components/Header.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (2)
- src/app/page.tsx
- src/components/Header.tsx
Additional comments not posted (5)
package.json (5)
9-9
: LGTM! Scriptlint
is correctly defined.The
lint
script usesnext lint
which is appropriate for a Next.js project.
10-10
: LGTM! Scriptts
is correctly defined.The
ts
script usestsc --noEmit
to check for type errors without emitting output files.
11-11
: LGTM! Scripttypecheck
is correctly defined.The
typecheck
script usestsc --pretty --noEmit
to check for type errors with pretty output formatting.
12-12
: LGTM! Scriptformat:fix
is correctly defined.The
format:fix
script usesprettier --write
to fix formatting errors in the specified file types.
13-13
: LGTM! Scriptformat:check
is correctly defined.The
format:check
script usesprettier --check
to check for formatting errors in the specified file types.
closes #40 |
Adding CI/CD workflows
Workflows Added:
Scripts Added:
typecheck
: To check typesformat:fix
: To fix the format errorsformat:check
: To check the format errorsRelated To #24
Summary by CodeRabbit
New Features
Chores
Style
Refactor
package.json
scripts for linting and formatting.