Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress blobs before saving them; uncompress on read #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benaadams
Copy link

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2021

CLA assistant check
All committers have signed the CLA.

@benaadams
Copy link
Author

Checks ran too fast; is it not picking up the AzureStorageConnectionString connection string value?

@ejsmith
Copy link
Contributor

ejsmith commented Mar 2, 2021

I've been thinking about this and I'm not sure if it's a good idea. If I store blobs in azure storage uncompressed, then I can use any storage client to go look at those files and download them, etc. If I am compressing them, I lose that ability. Also, it just seems like compression should be the choice of the caller and that we shouldn't force compression on every blob. That being said, I don't know how this impacts performance. Could we do the same thing you are doing with renting buffers from the caller side? Or maybe we could make this an option where you could turn on compression and it would do this for every blob like you are doing in this PR. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants