Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added choosing first day of the week (#19) #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Apr 3, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added a dialog for choosing first day of the week to any day.
  • By default, first day of the week is:
    • If a user in the old version of the app had set an option that Sunday should be first, Sunday will be set as a first day. Code for that is in MainActivity and can be removed in the next version after releasing this one.
    • If there wasn't anything set earlier, it will use the default first day of the week for current locale (same as in Calendar).
  • Modified the sorting by day logic to consider different first days of the week. Also, simplified that logic a bit.
  • Modified the alarm edit dialog to sort days properly.

Before/After Screenshots/Screen Record

qemu-system-x86_64_I2iSfeKKHL.mp4

Fixes the following issue(s)

Acknowledgement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting first day of week to any day
1 participant