Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate gesture handling code in cartesian axis #481

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Jan 20, 2025

Description

Draft for now to think about it -- this removes the majority of the gesture handling code inside the CartesianChart into its own component in order to attempt to clarify the complexity of the component.

How Has This Been Tested?

Clicked through existing charts

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

zibs added 2 commits January 20, 2025 09:22
separates it out of the body of `CartesianChart`
@zibs zibs requested a review from keithluchtel January 20, 2025 18:57
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: 2bf1775

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 10:22pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant