(#478) allocate once and reuse memory for env vars #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForNeVeR
requested changes
Jan 22, 2024
Cesium.Runtime/StdLibFunctions.cs
Outdated
| { | ||
| return null; | ||
| } | ||
|
|
||
| return StdIoFunctions.MarshalStr(Environment.GetEnvironmentVariable(str)); | ||
| _envVarsStorage ??= InitEnvVarsStorage(); |
There was a problem hiding this comment.
I am a little concerned about the thread safety here. If two threads enter this field, then _envVarsStorage will just silently leak.
Let's just make it Lazy? What do you think?
There was a problem hiding this comment.
Good point! Fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478