Cleanup and benchmark refresh

FlatlinerDOA · May 12, 2024 · 6833603 · 6833603
1 parent a4ccb1f
commit 6833603
Show file tree

Hide file tree

Showing 13 changed files with 127 additions and 94 deletions.
diff --git a/README.md b/README.md
diff --git a/benchmarks/CreateNewWithLength10.cs b/benchmarks/CreateNewWithLength10.cs
@@ -8,14 +8,16 @@ namespace Benchmarks;
 [MemoryDiagnoser]
 public class CreateNewWithLength10
 {
+    private char[] array = new[] { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9' };
+
     [Benchmark(Description ="string.ToRope()")]
     public void RopeOfCharFromString() => _ = "0123456789".ToRope();
 
     [Benchmark(Description = "new Rope<char>(array)")]
-    public void RopeOfCharFromArray() => _ = new Rope<char>(new[] { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9' });
+    public void RopeOfCharFromArray() => _ = new Rope<char>(this.array);
 
     [Benchmark(Description = "new List<char>(array)")]
-    public void ListOfCharFromArray() => _ = new List<char>(new[] { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9' });
+    public void ListOfCharFromArray() => _ = new List<char>(this.array);
 
     [Benchmark(Description = "new StringBuilder(string)")]
     public void StringBuilder() => _ = new StringBuilder("0123456789");

diff --git a/benchmarks/SplitThenConcat.cs b/benchmarks/SplitThenConcat.cs
@@ -11,19 +11,6 @@ public class SplitThenConcat
     [Params(10, 100, 1000)]
     public int EditCount;
 
-    [Benchmark]
-    public void ListOfChar()
-    {
-        var s = new List<char>(BenchmarkData.LoremIpsum);
-        for (int i = 0; i < EditCount; i++)
-        {
-            s.RemoveRange(321, s.Count - 322); //  =  new StringBuilder(s.ToString()[..321]);
-            s.AddRange(BenchmarkData.LoremIpsum);
-        }
-
-        ////s.ToString();
-    }
-
     [Benchmark]
     public void RopeOfChar()
     {
@@ -50,4 +37,17 @@ public void StringBuilder()
 
         ////s.ToString();
     }
+
+    [Benchmark]
+    public void ListOfChar()
+    {
+        var s = new List<char>(BenchmarkData.LoremIpsum);
+        for (int i = 0; i < EditCount; i++)
+        {
+            s.RemoveRange(321, s.Count - 322); //  =  new StringBuilder(s.ToString()[..321]);
+            s.AddRange(BenchmarkData.LoremIpsum);
+        }
+
+        ////s.ToString();
+    }
 }
diff --git a/benchmarks/results/Benchmarks.AddRange-barplot.png b/benchmarks/results/Benchmarks.AddRange-barplot.png
diff --git a/benchmarks/results/Benchmarks.AddRangeImmutable-barplot.png b/benchmarks/results/Benchmarks.AddRangeImmutable-barplot.png
diff --git a/benchmarks/results/Benchmarks.CreateNewEmpty-barplot.png b/benchmarks/results/Benchmarks.CreateNewEmpty-barplot.png
diff --git a/benchmarks/results/Benchmarks.CreateNewWithLength10-barplot.png b/benchmarks/results/Benchmarks.CreateNewWithLength10-barplot.png
diff --git a/benchmarks/results/Benchmarks.Equals-barplot.png b/benchmarks/results/Benchmarks.Equals-barplot.png
diff --git a/benchmarks/results/Benchmarks.IndexOf-barplot.png b/benchmarks/results/Benchmarks.IndexOf-barplot.png
diff --git a/benchmarks/results/Benchmarks.InsertRange-barplot.png b/benchmarks/results/Benchmarks.InsertRange-barplot.png
diff --git a/benchmarks/results/Benchmarks.SplitThenConcat-barplot.png b/benchmarks/results/Benchmarks.SplitThenConcat-barplot.png
diff --git a/src/Compare/Diff.cs b/src/Compare/Diff.cs
@@ -22,7 +22,6 @@
 namespace Rope.Compare;
 
 using System;
-using System.Drawing;
 
 /// <summary>
 /// Record struct representing one diff operation.

diff --git a/tests/RopeConstructionTests.cs b/tests/RopeConstructionTests.cs
@@ -1,11 +1,8 @@
 namespace Rope.UnitTests;
+
 using System;
 using System.Collections;
-using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
 
 [TestClass]
 public class RopeConstructionTests