Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for creating identity overrides #5035

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

rolodato
Copy link
Member

Tested by making manual requests and inspecting requests made by the frontend.

@rolodato rolodato requested a review from a team as a code owner January 22, 2025 21:27
@rolodato rolodato requested review from matthewelwell and removed request for a team January 22, 2025 21:27
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 3:57pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 3:57pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 3:57pm

@github-actions github-actions bot added the docs Documentation updates label Jan 22, 2025
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of minor comments.


Creating an identity override requires the following information:

* Environment ID to create the override in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that 'Environment ID' here is misleading? We should (unfortunately) use environment API key?

docs/docs/clients/rest.md Outdated Show resolved Hide resolved
@rolodato rolodato merged commit c70e72c into main Jan 27, 2025
9 of 10 checks passed
@rolodato rolodato deleted the docs/identity-overrides branch January 27, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants