Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MFA Method debugging / support improvements #4989

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthewelwell
Copy link
Contributor

Changes

Add created_at and updated_at to MFAMethod class. Note that I chose not to use auto_now and auto_now_add because I wanted existing records to only be marked as updated once they have in fact been updated to avoid confusion.

How did you test this code?

N/a - trivial changes

@matthewelwell matthewelwell requested a review from a team as a code owner January 10, 2025 17:58
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team January 10, 2025 17:58
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 10, 2025 5:58pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jan 10, 2025 5:58pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jan 10, 2025 5:58pm

@github-actions github-actions bot added api Issue related to the REST API chore labels Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4989 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4989 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4989 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4989 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4989 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4989 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Uffizzi Ephemeral Environment deployment-59787

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4989

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.39%. Comparing base (8cd2731) to head (aeab732).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/custom_auth/mfa/trench/admin.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4989      +/-   ##
==========================================
- Coverage   97.39%   97.39%   -0.01%     
==========================================
  Files        1191     1192       +1     
  Lines       41633    41652      +19     
==========================================
+ Hits        40549    40567      +18     
- Misses       1084     1085       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect us to actually ever modify existing MFA methods, but ideally we shouldn't allow editing the created/updated_at fields from the details page:

image

Not a blocker since this still solves the immediate issue, but otherwise LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants