fix: Remove is_enterprise check #4984
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4984 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 1191 1191
Lines 41630 41630
=======================================
Hits 40546 40546
Misses 1084 1084 ☔ View full report in Codecov by Sentry. |
| if is_enterprise() and hasattr( | ||
| self.organisation, "licence" | ||
| ): # pragma: no cover | ||
| if hasattr(self.organisation, "licence"): # pragma: no cover |
There was a problem hiding this comment.
Sorry, I'm super confused now. The is_enterprise() function is unrelated to the data in the database - it is just checking whether the image that's being used is the enterprise version.
This change will not resolve the issue highlighted by @rolodato here (if indeed it is an issue, or maybe this whole thing was just a miscommunication?).
There was a problem hiding this comment.
I believe this was a whole chain of miscommunication. The steps @rolodato outlined were a miscommunication by me since I thought that the is_enterprise() check hit the database and mentioned it to him.
There was a problem hiding this comment.
Ok I'm going to close this PR now, since we want to keep the is_enterprise() check.
Changes
This enables allowing licences without having to check the
is_enterprisefunction.How did you test this code?
Simple change. Did not test.