Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds Licensing upload tab #4934

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat: Adds Licensing upload tab #4934

merged 1 commit into from
Jan 17, 2025
+183 −6

Conversation

tiagoapolo
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Reference: #4923

This pull request introduces a new feature for uploading organization licensing files. The changes primarily focus on adding new endpoints, updating types, and integrating the new functionality into the existing UI components.

  • Added a new service for uploading organization licenses, including a mutation endpoint and a function to dispatch the upload action.
  • Created a new component for the Licensing tab content, allowing users to select and upload license files.
  • Integrated the Licensing tab into the organization settings page, making it visible for enterprise users (not SaaS).
  • Added optional chaining to safely access the focus method.
Screenshot 2024-12-19 at 17 04 28

How did you test this code?

Tested mannualy

@tiagoapolo tiagoapolo requested a review from a team as a code owner December 19, 2024 20:08
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team December 19, 2024 20:08
@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:53am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:53am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4934 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4934 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4934 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4934 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4934 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4934 Finished ✅ Results ✅

@tiagoapolo tiagoapolo self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Uffizzi Preview deployment-59259 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 19, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jan 2, 2025
@matthewelwell
Copy link
Contributor

As far as I can tell, it's not possible (or at least difficult) to test this PR without this code.

@tiagoapolo
feat: Adds Licensing upload tab
4d88538 
get value from image

Signed-off-by: Tiago Fonseca <[email protected]>

fix

Signed-off-by: Tiago Fonseca <[email protected]>

addressing comments

addressing comments
@tiagoapolo tiagoapolo force-pushed the feat/upload-licensing-4923 branch from 883b844 to 4d88538 Compare January 17, 2025 10:50
@tiagoapolo tiagoapolo requested a review from kyle-ssg January 17, 2025 10:50
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jan 17, 2025
matthewelwell
matthewelwell approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@tiagoapolo tiagoapolo merged commit 5e1c1be into main Jan 17, 2025
32 checks passed
@tiagoapolo tiagoapolo deleted the feat/upload-licensing-4923 branch January 17, 2025 15:18
@flagsmithdev flagsmithdev mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg

Assignees

@tiagoapolo tiagoapolo

Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagoapolo @matthewelwell @kyle-ssg