Modernize codebase to be fully async #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncalossilva
commented
Sep 29, 2023
|
@gagantrivedi perhaps I could get your feedback here? 🙏 |
5 seconds is also httpx's default.
khvn26
approved these changes
Oct 25, 2023
|
Hey! Is there anything preventing this merge? We could do away with our internal fork once it is. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the performance work started in #75 and continued on #76.
This time, making the application fully compatible with async. This doesn't lead to better performance, but it does lead to better consistency. While before we were seeing the maximum CPU utilization jumping up and down, it now stays mostly flat, in parallel with average CPU utilization. This improves predictability our ability to detect problems and situations of under/over-provisioning.