去除 defaults 的常量

config/parse.go

@@ -26,6 +26,8 @@ const (
 	KB
 	MB
 	GB
+
+	Day = 24 * time.Hour
 )
 
 // parseByteSize parse size with given unit information.
@@ -89,7 +91,7 @@ func parseTimeDuration(s string) (time.Duration, error) {
 			return 0, err
 		}
 
-		return time.Duration(days) * 24 * time.Hour, nil
+		return time.Duration(days) * Day, nil
 	}
 
 	return time.ParseDuration(s)

rotate/config.go

@@ -17,6 +17,13 @@ package rotate
 import (
 	"os"
 	"time"
+
+	"github.com/FishGoddess/logit/defaults"
+)
+
+const (
+	MB  = 1024 * 1024
+	Day = 24 * time.Hour
 )
 
 // config stores some fields of file.
@@ -46,11 +53,11 @@ type config struct {
 // newDefaultConfig returns a default config.
 func newDefaultConfig() config {
 	return config{
-		mode:       0644,
-		dirMode:    0755,
+		mode:       defaults.FileMode,
+		dirMode:    defaults.FileDirMode,
 		timeFormat: "20060102150405",
-		maxSize:    256 * 1024 * 1024,   // 256 MB
-		maxAge:     90 * 24 * time.Hour, // 90 days
+		maxSize:    256 * MB,
+		maxAge:     90 * Day,
 		maxBackups: 100,
 	}
 }

writer/buffer.go

@@ -24,7 +24,7 @@ import (
 const (
 	// minBufferSize is the min size of buffer.
 	// A panic will happen if buffer size is smaller than it.
-	minBufferSize = 4
+	minBufferSize = 16
 )
 
 // bufferWriter is a writer having a buffer inside to reduce times of writing underlying writer.
@@ -49,8 +49,8 @@ type bufferWriter struct {
 // Notice that bufferSize must be larger than minBufferSize or a panic will happen. See minBufferSize.
 // The size we want to use is bufferSize, but we add more bytes to it for avoiding buffer growing up.
 func newBufferWriter(writer io.Writer, bufferSize uint64) *bufferWriter {
-	if bufferSize <= minBufferSize {
-		panic(fmt.Errorf("bufferSize %d <= minBufferSize %d", bufferSize, minBufferSize))
+	if bufferSize < minBufferSize {
+		panic(fmt.Errorf("bufferSize %d < minBufferSize %d", bufferSize, minBufferSize))
 	}
 
 	return &bufferWriter{