Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specific configuration for Filigran #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Specific configuration for Filigran #1

wants to merge 5 commits into from
+619 −6

Conversation

ThibaultFiligran
Copy link

@ThibaultFiligran ThibaultFiligran commented Dec 30, 2024 •
edited
Loading

Redis Sentinel Changes
🛠 Configuration Improvements

  • New Standalone Mode: Added automatic master discovery logic
    • First checks sentinel sidecars on StatefulSet pods
    • Then checks Redis nodes directly
    • Falls back to node-0 if no master is found
  • Better Error Handling

🔒 Security

  • Cilium Network Policy: New file to manage network policies
  • Cross-namespace communication support
  • Egress/ingress rules configuration for Redis and Sentinel
  • Prometheus monitoring options

🔧 Configuration
Dependencies: Updated to use local common charts

  • Changed from registry-1.docker.io/bitnamicharts to file://../common
  • Common version maintained at 2.28.0
    (feel free to revert, it's only to be able to use helm template locally)

💡 General Improvements
Increased master retrieval timeout (5 to 10 seconds)
Dynamic use of replicaCount for node iteration

@ThibaultFiligran
Create a new config for standalone sentinel
77e9dbf
@ThibaultFiligran
Rename cilium policy
a0453b4
@ThibaultFiligran
Remove redis-data PVC for standalone sentinel
2977fc9
@ThibaultFiligran
Remove Extra end
51a6752
@ThibaultFiligran
fix(redis): improve sentinel script and logging
6334469 
- Fix printf commands by removing trailing quotes
- Add more detailed logging in standalone mode:
  * Log when standalone mode is enabled
  * Log each node iteration for both sentinel and redis checks
- Use replicaCount from values for node iteration
- Keep failback behavior when sentinel info is not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ThibaultFiligran