Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced all deadlinks with wayback links #1143

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

jfdev001
Copy link
Contributor

@jfdev001 jfdev001 commented Feb 3, 2025

This PR address issue #1142

Replaced dead links that provided information about the finite elements with the corresponding wayback links. This is still not ideal since in some cases, the wayback machine did not archive a related URL (e.g., the definition for the basis functions for the 1st order BubbleEnrichedLagrange on a triangular element is not accessible: https://web.archive.org/web/20250000000000*/https://defelement.com/elements/examples/triangle-bubble-enriched-lagrange-1.html).

A possible solution that I plan on trying this week is to add to src/interpolations.jl permalinks to the files from https://github.com/DefElement/DefElement that provide information on the interpolation definitions but whose HTML pages are not archived by the wayback machine. The DefElement files that provide this interpolation information should be findable in the commit history of https://github.com/DefElement/DefElement. The PR should remain in draft mode until this can be resolved.

@KnutAM
Copy link
Member

KnutAM commented Feb 4, 2025

Thanks!

It seems like all the shape functions are missing from defelement? Not just the 3rd order quadrilaterals? I cannot see them neither on computer nor phone...

Then I think we should fix it upstream if it isn't just a single interpolation. Could be related to DefElement/DefElement#382? But I don't know how their website is built, so not sure...

Do you want to open at issue at defelement? (If not, I can do of course)

@jfdev001
Copy link
Contributor Author

jfdev001 commented Feb 4, 2025

Correct! The shape functions are missing from defelement in general. This appears to be the case for more than just the 3rd order lagrange on quadrilaterals. The wayback links show you the shape functions, so it's a temporary fix.

I have opened an issue now at https://github.com/DefElement/DefElement

src/interpolations.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (1807f66) to head (dee57d2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          39       39           
  Lines        6087     6087           
=======================================
  Hits         5697     5697           
  Misses        390      390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Knut Andreas Meyer <[email protected]>
Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just validated that the links contain the correct information, with the change below, it should be good to go IMO.

src/interpolations.jl Outdated Show resolved Hide resolved
@KnutAM KnutAM merged commit 7ff967c into Ferrite-FEM:master Feb 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants