Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: deadlinks to defelement.com in interpolations.jl #1142

Open
jfdev001 opened this issue Feb 3, 2025 · 1 comment
Open

Docs: deadlinks to defelement.com in interpolations.jl #1142

jfdev001 opened this issue Feb 3, 2025 · 1 comment

Comments

@jfdev001
Copy link

jfdev001 commented Feb 3, 2025

In src/interpolations.jl there are dead links for sources of reference finite elements (e.g., src/interpolations.jl#L670)

function reference_shape_value(ip::Lagrange{RefQuadrilateral, 3}, ξ::Vec{2}, i::Int)
    # See https://defelement.com/elements/examples/quadrilateral-Q-3.html
    ...

These links could either (1) be removed (not ideal since obviously the information at the links inspired the function bodies), (2) should be replaced with a new source (using the same website now www.defelement.org or a different source), or (3) replaced with a wayback machine link (e.g., https://web.archive.org/web/20220817132305/https://defelement.com/elements/examples/quadrilateral-Q-3.html).

Option (3) is the easiest, and I can open a PR for this. Option (2) may not be feasible since the new website www.defelement.org does not seem to provide the functionals and basis functions for desired interpolation on an element (see e.g., https://defelement.org/elements/examples/quadrilateral-lagrange-equispaced-3.html). I could also open an issue in the DefElement repo since not listing the functionals and basis functions of shape functions on a particular element type is not ideal.

@KnutAM
Copy link
Member

KnutAM commented Feb 3, 2025

Nice catch!
Using the wayback temporarily and opening a pr/issue at defelement seems like the best option to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants