-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solidity #33
Merged
Merged
Update solidity #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2025
7f1fe96
to
5a8bacb
Compare
thaarok
requested changes
Jan 30, 2025
c8c07e7
to
377f737
Compare
thaarok
reviewed
Jan 31, 2025
b27548a
to
b2fc469
Compare
Draft
Mike-CZ
reviewed
Feb 4, 2025
Mike-CZ
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thaarok
approved these changes
Feb 5, 2025
4f7ecb6
to
b7721f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on changes from #31 and #32 so those should be merged before reviewing this one.
This PR updates version of solidity to
0.8.27
and uses hardhat evmVersioncancun
It also makes all necessary changes that are required by this solidity version such as:
[]bytes
instead of[]bytes32
for voting optionsvirtual
andoverride
to some inherited methodsdelete
when wiping an array instead of setting its len to 0memory
instead ofcalldata
inaddTemplate
inProposalTeplates.sol
due errorStack too deep
openzepelin
and/or funcs for type casting