Skip to content

Commit

Permalink
rollback renaming of pType
Browse files Browse the repository at this point in the history
  • Loading branch information
cabrador committed Jan 30, 2025
1 parent 09df829 commit aac7014
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions contracts/governance/Governance.sol
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ contract Governance is Initializable, ReentrancyGuard, GovernanceSettings, Versi
/// @return votingStartTime The start time of the voting.
/// @return votingMinEndTime The minimum end time of the voting.
/// @return votingMaxEndTime The maximum end time of the voting.
function proposalParams(uint256 proposalID)
public view returns (
function proposalParams(uint256 proposalID) public view returns (
uint256 pType,
Proposal.ExecType executable,
uint256 minVotes,
Expand Down Expand Up @@ -271,7 +270,16 @@ contract Governance is Initializable, ReentrancyGuard, GovernanceSettings, Versi
require(options.length != 0, "proposal options are empty - nothing to vote for");
require(options.length <= maxOptions(), "too many options");
bool ok;
ok = proposalVerifier.verifyProposalParams(pType, executable, minVotes, minAgreement, opinionScales, votingStartTime, votingMinEndTime, votingMaxEndTime);
ok = proposalVerifier.verifyProposalParams(
pType,
executable,
minVotes,
minAgreement,
opinionScales,
votingStartTime,
votingMinEndTime,
votingMaxEndTime
);
require(ok, "proposal parameters failed verification");
ok = proposalVerifier.verifyProposalContract(pType, proposalContract);
require(ok, "proposal contract failed verification");
Expand Down

0 comments on commit aac7014

Please sign in to comment.