Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Log4jTextFormatter and Log4netTextFormatter #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xced
Copy link

@0xced 0xced commented Jun 29, 2023

Description

Recommend using Serilog.Formatting.Log4Net instead.

Serilog.Formatting.Log4Net is better that the provided Log4jTextFormatter and Log4netTextFormatter classes as it is configurable and well documented.

Disclaimer: I am the author of Serilog.Formatting.Log4Net. 😉

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@FantasticFiasco
Copy link
Owner

Hi @0xced!

I've given this some thought, weighting pros and cons. On the positive side it means that I can delete code, that I don't have to manage it anymore. That is great! On the negative side I lose control and introduce risk. Looking at the changes in the specific files, there hasn't been any for a really long time. That diminishes the value of this change. Also, dependencies comes at a cost. For a user this means taking a dependency not on one NuGet package but instead two. And although Dependabot and Renovate are fantastic tools for dependency management, I must believe that many companies host their source on-prem, where these tools cannot run. As a user there's also is the fear on the compatibility matrix between the two tools.

Let's leave this PR open, but I won't merge it until I get more feedback or encounter a problem with my implementation that would be solved by your implementation. I wish you all the best of luck in your open source endeavour!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants