Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssh): add signed ssh certificates lab #36

Closed
wants to merge 1 commit into from

Conversation

fxkk
Copy link

@fxkk fxkk commented Jan 12, 2024

@FalcoSuessgott I've also taken a shot at creating a lab, does it look good or are you still missing something? :-)

@FalcoSuessgott
Copy link
Owner

FalcoSuessgott commented Jan 12, 2024

nice PR, really like the documentation.

Just a few things:

  • add the lab in the README, as well as in docs/home.md
  • add a test scenario in tests/e2e.tftest.hcl, I believe you could simply run something like ssh <IP> cat <any-json-file>.json. Unfortunately, the ssh command must return valid json. You then can write simple assertions for that json file. If there isn't really any json file to output, you could probably just add one in docker_container.ubuntu.

Best,

Tom

@fxkk fxkk closed this by deleting the head repository Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants