Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading LEVEL_3_MIN field #4074

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

Chocohead
Copy link
Contributor

LEVEL_3 is 1 - 3 (e.g. non-empty cauldrons), so a constant field of zero won't be its minimum.
LEVEL_8 is 0 - 8 (e.g. composters), and is just after, so field_31387 is more likely to be for that.

It does leave field_31388 immediately underneath in a slightly awkward position, as it's a constant of one, so could either be LEVEL_1_8_MIN (as it is now) or LEVEL_3_MIN (to match field_31389 immediate after it).
I suppose field_31390 is in a similar position being a constant of eight, it could be LEVEL_1_8_MAX (as it is now) or LEVEL_8_MAX (to correspond to LEVEL_8_MIN).

`LEVEL_3` is 1 - 3, so a constant field of zero isn't its minimum
@Shnupbups Shnupbups added bug Fixes or discusses a bug within the mappings refactor A PR that renames existing names. release A PR that targets a release version of Minecraft labels Jan 2, 2025
@Shnupbups Shnupbups merged commit 63c5b42 into FabricMC:1.21.4 Jan 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings refactor A PR that renames existing names. release A PR that targets a release version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants