New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename `CommandTreeS2CPacket.rootSize` to `rootIndex` #4073

Merged

Shnupbups merged 1 commit into FabricMC:1.21.4 from 0x000006:1.21.4

Jan 2, 2025

Contributor

0x000006 commented Jan 1, 2025

It would be more logical because it has nothing to do with size/length.

This is the context it is used in:

// CommandTreeS2CPacket lines 183 - 185
public RootCommandNode<CommandSource> getCommandTree(CommandRegistryAccess commandRegistryAccess) {
    return (RootCommandNode)new CommandTree(commandRegistryAccess, this.nodes).getNode(this.rootSize /* here */);
}


          Rename CommandTreeS2CPacket.rootSize to rootIndex

dcf3105

Shnupbups approved these changes

View reviewed changes

Shnupbups added bug release labels

Shnupbups merged commit 1a7852e into FabricMC:1.21.4

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels