Renamed Direction.idHorizontal and related methods
#4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since |
|
Good spot, I hadn't noticed these. |
Octol1ttle
reviewed
Nov 1, 2024
| @@ -51,7 +51,7 @@ CLASS net/minecraft/class_2350 net/minecraft/util/math/Direction | |||
| ARG 1 y | |||
| ARG 2 z | |||
| METHOD method_10148 getOffsetX ()I | |||
| METHOD method_10150 fromRotation (D)Lnet/minecraft/class_2350; | |||
| METHOD method_10150 fromHorizontalDegrees (D)Lnet/minecraft/class_2350; | |||
| ARG 0 rotation | |||
There was a problem hiding this comment.
rename the argument as well?
There was a problem hiding this comment.
Done. I believe angle would suffice for this one in particular.
Octol1ttle
approved these changes
Nov 1, 2024
apple502j
previously approved these changes
Nov 6, 2024
modmuss50
added
the
update-base
github-actions
bot
dismissed
apple502j’s stale review
The base branch was changed.
|
🚀 Target branch has been updated to 24w46a |
github-actions
bot
added
snapshot
modmuss50
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field
Direction.idHorizontaldoesn't make sense to interpret as an id, and it certainly doesn't correspond the id of any other direction. This field's value is very frequently multiplied by 90 to obtain an angle in degree, so it makes more sense to to see it as the number of horizontal quarter turns required to face this direction.asRotation()does precisely that, so I renammed it togetPositiveHorizontalDegrees(). It does almost the same job as the existinggetHorizontalDegrees(Direction), except that the later throws when fed a vertical direction, and returns angles wrapped between -90° and 180°. The "positive" counterpart returns angles wrapped between 0° and 270°.I renamed
getHorizontalDegreestogetHorizontalDegreesOrThrowto further emphasize the difference in behaviour.