Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic class mappings for new packets added in 24w04a #3761

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Add basic class mappings for new packets added in 24w04a #3761

merged 4 commits into from
Jan 17, 2024

Conversation

wgaylord
Copy link
Contributor

These classes were discovered based on the 24w03a snapshot article and the names of enums in the source code.

@Shnupbups
Copy link
Contributor

Could you please map their CODEC fields and write methods?

@Shnupbups Shnupbups added new A PR that maps mainly new names snapshot A PR that targets a snapshot version of Minecraft labels Jan 17, 2024
@wgaylord
Map CODEC field and write field in packets, also map MAX_COOKIE_LENGT…
e7f9d16 
…H, move ServerTransfer Packet to correct package.
@wgaylord
Copy link
Contributor Author

Mapped the CODEC field and write methods on all 4 packets also mapped the static final field on that represents the max length of a cookie.

Also moved the transfer packet into the correct package.

@Shnupbups Shnupbups merged commit 22ce794 into FabricMC:24w03a Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnupbups Shnupbups Shnupbups approved these changes

Assignees
No one assigned
Labels
new A PR that maps mainly new names snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgaylord @Shnupbups