Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ClickableWidget#renderButton to ClickableWidget#renderWidget #3741

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Update ClickableWidget#renderButton to ClickableWidget#renderWidget #3741

merged 1 commit into from
Nov 24, 2023

Conversation

dicedpixels
Copy link
Contributor

Since the EntryListWidget now extends ClickableWidget, ClickableWidget's renderButton is updated to have more generic name; renderWidget.

@apple502j apple502j added refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft impactful A change that is likely to affect some mods. Will require more reviews. labels Nov 24, 2023
@haykam821 haykam821 requested a review from a team November 24, 2023 03:07
@modmuss50
Copy link
Member

I know this is a little impactful, but its best to do this rename sooner rarther than later 👍

@modmuss50 modmuss50 merged commit 51dd989 into FabricMC:1.20.3-pre2 Nov 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apple502j apple502j apple502j approved these changes

@haykam821 haykam821 haykam821 approved these changes

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
impactful A change that is likely to affect some mods. Will require more reviews. refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dicedpixels @modmuss50 @haykam821 @apple502j