Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename grass to short grass #3733

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

YanisBft
Copy link
Contributor

And update enigma

@YanisBft YanisBft requested a review from a team as a code owner November 20, 2023 17:36
@YanisBft YanisBft added refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft labels Nov 20, 2023
@ErrorCraft
Copy link
Contributor

Blocks.GRASS should also be renamed to SHORT_GRASS.

@haykam821
Copy link
Contributor

Is Blocks.SHORT_GRASS not already the name? The name should come from the string used in the method call to register the block.

@YanisBft
Copy link
Contributor Author

Yeah double-checked, the name is auto-generated

@ErrorCraft
Copy link
Contributor

Ah, alright. Wouldn't the item names be auto-generated too then, or does it not generate SHORT_GRASS because it doesn't have a string in the method it calls where it can take the name from?

@YanisBft
Copy link
Contributor Author

Ah, alright. Wouldn't the item names be auto-generated too then, or does it not generate SHORT_GRASS because it doesn't have a string in the method it calls where it can take the name from?

Exactly, names of block items are not generated because there's no string in the register method

@haykam821
Copy link
Contributor

The item fields are initialized like Items.register(SHORT_GRASS), so there isn't a string to derive a name from. However, FabricMC/name-proposal#9 expands the field naming system to support additional name providers, and naming fields transitively is a possibility.

@modmuss50 modmuss50 merged commit 71c5dfb into FabricMC:1.20.3-pre1 Nov 21, 2023
3 checks passed
@YanisBft YanisBft deleted the 1.20.3-pre1-short-grass branch November 21, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants