Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map trial spawner #3720

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Map trial spawner #3720

merged 3 commits into from
Nov 9, 2023

Conversation

MattiDragon
Copy link
Contributor

I've begun mapping the trial spawner code. I don't have time to finish today, but I'd like some reviews already.

@Shnupbups
Copy link
Contributor

Please remove the underscore from the package name, and put TrialSpawnerState in the block enum package

@apple502j apple502j marked this pull request as ready for review November 9, 2023 12:34
@apple502j apple502j added new A PR that maps mainly new names snapshot A PR that targets a snapshot version of Minecraft labels Nov 9, 2023
@MattiDragon
Copy link
Contributor Author

Some notes:

  • There's an unmapped record class that looks like it holds trial spawner config.
  • There are still many unmapped methods

Shnupbups
Shnupbups approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Shnupbups Shnupbups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will resolve conflicts with my PR soon

@apple502j apple502j merged commit 91e8872 into FabricMC:23w45a Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benonardo Benonardo Benonardo left review comments

@Shnupbups Shnupbups Shnupbups approved these changes

Assignees
No one assigned
Labels
new A PR that maps mainly new names snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattiDragon @Shnupbups @Benonardo @apple502j