Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the Blocks.createStairs method to createStairsBlock #3713

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Rename the Blocks.createStairs method to createStairsBlock #3713

merged 1 commit into from
Nov 1, 2023

Conversation

haykam821
Copy link
Contributor

This pull request fixes an inconsistency regarding factory methods in the Blocks class, as all other factory methods within the Blocks class that return a Block instance are suffixed.

@haykam821 haykam821 requested a review from a team November 1, 2023 03:36
@haykam821 haykam821 added bug Fixes or discusses a bug within the mappings refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft labels Nov 1, 2023
@apple502j apple502j merged commit 5467c9a into FabricMC:23w43b Nov 1, 2023
7 checks passed
@haykam821 haykam821 deleted the blocks-createstairsblock branch November 1, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apple502j apple502j apple502j approved these changes

Assignees
No one assigned
Labels
bug Fixes or discusses a bug within the mappings refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haykam821 @apple502j