Add c:flowers, c:flowers/tall, and c:flowers/small block and item tags
#4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
reviewed
Jan 5, 2025
...tagen/java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/BlockTagGenerator.java
Show resolved
Hide resolved
...on-tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java
Outdated
Show resolved
Hide resolved
...on-tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java
Outdated
Show resolved
Hide resolved
...on-tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java
Outdated
Show resolved
Hide resolved
…i/tag/convention/v2/ConventionalItemTags.java Co-authored-by: Juuz <[email protected]>
…i/tag/convention/v2/ConventionalItemTags.java Co-authored-by: Juuz <[email protected]>
…i/tag/convention/v2/ConventionalItemTags.java Co-authored-by: Juuz <[email protected]>
…/fabric into FlowerTagRevival
modmuss50
approved these changes
Jan 14, 2025
modmuss50
added
merge me please
modmuss50
pushed a commit
that referenced
this pull request
Jan 14, 2025
…em tags (#4352) * Add `c:flowers`, `c:flowers/tall`, and `c:flowers/small` block and item tags * Apply spotless * remove warning on flowers block tag * Update fabric-convention-tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java Co-authored-by: Juuz <[email protected]> * Update fabric-convention-tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java Co-authored-by: Juuz <[email protected]> * Update fabric-convention-tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java Co-authored-by: Juuz <[email protected]> * remove small flower tag alias --------- Co-authored-by: Juuz <[email protected]> (cherry picked from commit dfeded7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mojang has recently rid
minecraft:tall_flowersblock tag andminecraft:tall_flowers/minecraft:flowersitem tags.What this PR aims to do is bring back and duplicate these flower tags under
cnamespace to make it safer for Modders to use without worry about Mojang deleting the rest of the flower tags in the future. We had multiple people ask where the flower item tag went so there is quite a number of people relying on a tag of flowers.The non-tag entries of the flower tags are in same order as the tags in past (with exception to eye blossom because vanilla has the open and closed entry far apart in the vanilla for no logical reason which drove me insane)
For Fabric side, the
cflower tags that still have a vanilla equivalent are aliased together.I also added entries to log warning to find people using vanilla tags that no longer exist and guide them to the new
ctagsBlocks:
c:flowers/tallc:flowers/smallc:flowersItems:
c:flowers/tallc:flowers/smallc:flowersAny issues with this? Is there any flower subcategory that is strongly desired beyond tall/small?
NeoForge PR: neoforged/NeoForge#1825