Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getKnownIndyBsms storing a set in a list without sorting #1225

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Fix getKnownIndyBsms storing a set in a list without sorting #1225

merged 2 commits into from
Nov 29, 2024

Conversation

jpenilla
Copy link
Contributor

This caused remapJar to re-run unnecessarily

modmuss50
modmuss50 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, Ill merge this into 1.9 (will be released shortly)

@modmuss50 modmuss50 changed the base branch from dev/1.8 to exp/1.9 November 28, 2024 20:45
@modmuss50
Copy link
Member

modmuss50 commented Nov 28, 2024 •
edited
Loading

Idk that this build error is about 😟 java.io.IOException: Failed to load eclipse groovy formatter: java.lang.RuntimeException: org.tukaani.xz.XZFormatException: Input is not in the XZ format (Clearly not your fault)

@modmuss50 modmuss50 merged commit e5ad4e1 into FabricMC:exp/1.9 Nov 29, 2024
36 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpenilla @modmuss50