Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matched filter improved. #42

Merged
merged 2 commits into from
Sep 16, 2024
Merged

matched filter improved. #42

merged 2 commits into from
Sep 16, 2024

Conversation

pravirkr
Copy link
Collaborator

Matched filter:

  • Astropy kernels are not helpful. Now, custom kernels are used, which gives more control over normalization.
  • Astropy convolve_fft is too complicated. We need a simple FFT-based convolution, so using numpy FFT functions with numba (rocket-fft).
  • In principle, this is based on spyden. Templates are also mean-subtracted to remove bias. Hopefully, this is correct!
  • It will be useful for the pulsar module + upcoming simulation module.

@pravirkr pravirkr self-assigned this Sep 16, 2024
@pravirkr pravirkr added the enhancement New feature or request label Sep 16, 2024
@pravirkr pravirkr merged commit 680917b into main Sep 16, 2024
8 checks passed
@pravirkr pravirkr deleted the filter_patch branch September 16, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant