#33 Implementation of buffered file read (WIP) #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #33, I have added some features to support buffered inputs for file reading. The code is currently implemented under a new
read_plan_buffered
method onFilReader
but as the behaviour is identical to that ofread_plan
(barring one optional argument) it may be sensible to replace the original code with the buffered code.Tests have been updated.
Testing on larger files also shows that this results in a significant performance improvement. For example, testing the time required to read and unpack a 2 GB file on a MacBook with an M2 processor we see a doubling of the performance: