Implement SysTexture for SDL_GPU backend #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
force-pushed
the
systexture
branch
2 times, most recently
from
2e04297 to
cc443d6
Compare
|
CancelGPUCommandBuffer being commented out is because I can't build locally with those calls in there, the link fails. I'm not sure if it's because something changed on the SDL side or what. |
This is caused by the way cmake (cmake-gui?) and windows and VS interact, if you don't use the .sln file from your Binaries directory to build you end up with stale lib files. So it's not on FNA3D's end. |
|
SDL's been updated so this should now be clear to rebase. |
…textures Implement SysTexture for SDL_GPU backend Add some asserts Update for typo fix in SDL_GPU headers
|
Verified again by hand with my 10-bit AV1 player test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this locally by using it to create R16_UNORM textures for my dav1dfile test and it worked (with a paired change to FNA to allow me to create a Texture2D instance around a SysTexture handle.)