Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require nanobind>=2.5.0 #3622

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Require nanobind>=2.5.0 #3622

merged 1 commit into from
Feb 9, 2025

Conversation

francesco-ballarin
Copy link
Member

Needed due to #3617. Otherwise the user may get odd errors like

#23 127.3       CMake Error at /usr/local/lib/python3.12/site-packages/nanobind/cmake/nanobind-config.cmake:316 (add_library):
#23 127.3         Cannot find source file:
#23 127.3       
#23 127.3           NB_SUPPRESS_WARNINGS
#23 127.3       Call Stack (most recent call first):
#23 127.3         CMakeLists.txt:34 (nanobind_add_module)
#23 127.3       
#23 127.3       
#23 127.3       CMake Error at /usr/local/lib/python3.12/site-packages/nanobind/cmake/nanobind-config.cmake:316 (add_library):
#23 127.3         No SOURCES given to target: cpp
#23 127.3       Call Stack (most recent call first):
#23 127.3         CMakeLists.txt:34 (nanobind_add_module)
#23 127.3       
#23 127.3       
#23 127.3       CMake Generate step failed.  Build files cannot be regenerated correctly.

@francesco-ballarin francesco-ballarin added install housekeeping Tidying and style improvements nanobind Issues related to nanobindings dependencies Pull requests that update a dependency file labels Feb 9, 2025
@garth-wells garth-wells added this pull request to the merge queue Feb 9, 2025
Merged via the queue into main with commit 797e47c Feb 9, 2025
34 checks passed
@garth-wells garth-wells deleted the francesco/nb-version branch February 9, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file housekeeping Tidying and style improvements install nanobind Issues related to nanobindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants