-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General tidy and restrict cffi < 1.17 due to static condensation demo issue #3343
Conversation
See also: |
I can reproduce. The issue seems to come from some changes in CFFI, so the global FFI builder object, i.e.
What seems to work is if we call |
Fix will come with python-cffi/cffi#111, I'd suggest we wait with pinned cffi==1.16.0 in the meantime. |
… issue (FEniCS#3343) * CFFI 1.17 seems to have issues with numba. * Clean up RedHat build. * Can people stop adding optional dependencies in CI runs? * Tidy. * Tidy. * General tidying. * Fix. * Remove logguru exception * Tidy up Dockerfile. * Fix. * Install cython for petsc4py build * Setuptools * Tweaks. * Fix. * Always build docs once and only push if on DOLFINx with main or v* tag. * Add back documentation artifacts. * Fix. * Fix. * Fix. * Need these, not installed (!). * petsc4py needs numpy. * Split apart numba/cffi and petsc/cffi definitions * Missing cffi! * Revert. * Try unpinning CFFI. * Does seem to be necessary. * Improve docstring.
… issue (FEniCS#3343) * CFFI 1.17 seems to have issues with numba. * Clean up RedHat build. * Can people stop adding optional dependencies in CI runs? * Tidy. * Tidy. * General tidying. * Fix. * Remove logguru exception * Tidy up Dockerfile. * Fix. * Install cython for petsc4py build * Setuptools * Tweaks. * Fix. * Always build docs once and only push if on DOLFINx with main or v* tag. * Add back documentation artifacts. * Fix. * Fix. * Fix. * Need these, not installed (!). * petsc4py needs numpy. * Split apart numba/cffi and petsc/cffi definitions * Missing cffi! * Revert. * Try unpinning CFFI. * Does seem to be necessary. * Improve docstring.
… issue (FEniCS#3343) * CFFI 1.17 seems to have issues with numba. * Clean up RedHat build. * Can people stop adding optional dependencies in CI runs? * Tidy. * Tidy. * General tidying. * Fix. * Remove logguru exception * Tidy up Dockerfile. * Fix. * Install cython for petsc4py build * Setuptools * Tweaks. * Fix. * Always build docs once and only push if on DOLFINx with main or v* tag. * Add back documentation artifacts. * Fix. * Fix. * Fix. * Need these, not installed (!). * petsc4py needs numpy. * Split apart numba/cffi and petsc/cffi definitions * Missing cffi! * Revert. * Try unpinning CFFI. * Does seem to be necessary. * Improve docstring.
Not totally clear why but there is an issue with the static condensation demo, numba and a new version of cffi. @michalhabera you can reproduce this by branching and removing the
cffi<1.17
restriction frompyproject.toml
.This PR also tidies up all of the CI pipelines; I would like to ask again, please do not put
pip install x y z
into pipelines. Please use the optional dependencies feature withinpyproject.toml
.I have also split apart cffi registering Numba's complex types and creating cffi PETSc wrappers - you can now use cffi with numba complex numbers without having PETSc installed. This was causing a test failure.