FHU: Switch over win32 file operations to std::filesystem #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
approved these changes
Apr 9, 2024
neobrain
reviewed
Apr 10, 2024
bylaws
force-pushed
the
ec_pt7
branch
2 times, most recently
from
500f27b to
fcf0fc6
Compare
These were broken to varying degrees across the board on win32, just switch to their std::filesystem as windows doesn't have the same allocator issues that require their reimplementation.
neobrain
approved these changes
Apr 11, 2024
Sonicadvance1
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were broken to varying degrees across the board on win32, just switch to their std::filesystem as windows doesn't have the same allocator issues that require their reimplementation.
NOTE: using std::filesystem within syscall callbacks (i.e. invalidation related code) would still cause issues, however I don't see that ever happening on the FEX side?