FEXLoader: Add some debug-only tracking for FEX owned FDs #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Mar 23, 2024
I remember seeing some application last year where they closed a FEX owned FD but now I don't remember what it was. This can really mess us up so add some debug tracking so we can try and find it again. Might be something specifically around flatpack, appimage, or chrome's sandbox. I have some ideas about how to work around these problems if they crop up but need to find the problem applications again.
Sonicadvance1
force-pushed
the
fd_tracking_check
branch
from
869a452 to
60755ac
Compare
alyssarosenzweig
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember seeing some application last year where they closed a FEX owned FD but now I don't remember what it was. This can really mess us up so add some debug tracking so we can try and find it again.
Might be something specifically around flatpack, appimage, or chrome's sandbox. I have some ideas about how to work around these problems if they crop up but need to find the problem applications again.