Library Forwarding: Don't map float/double to fixed-size integers #3494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d04c94f unintentionally changed behavior on 64-bit applications: In particular, the apitraces attached to #3488 (comment) show that the LOD bias passed to
glTexParameterf
differs before and after the change:It turns out GetTypeNameWithFixedSizeIntegers erroneously mapped float/double types to fixed-size integers, which led to wrong semantics (presumably bitcasting followed by rounding conversion, instead of plain copying). This mapping was done consistently for both host and guest, so this issue escaped my initial attempt at finding differences.
By fixing GetTypeNameWithFixedSizeIntegers,
thunkgen
now emitsGuestWrapperForHostFunction<void(uint32_t, uint32_t, float), uint32_t, uint32_t, float>::Call
for glTexParameterf, where previously thefloat
s would have been replaced byuint32_t
. Similar type checks have been updated to usebuiltin && integer
for consistency without functional change.Fixes #3455.
Supersedes #3488.