ASM: Another sign extend bug in #3421

[Sonicadvance1]

This time found in MGRR. It flips the problem space on its head.

Sorry @pmatos that I keep finding bugs and poking holes in your implementation.

[pmatos]

This time found in MGRR. It flips the problem space on its head.

Sorry @pmatos that I keep finding bugs and poking holes in your implementation.

Lovely. I will take a look. Thanks. How are you finding these? I assume MGRR is metal gear. Are you running games with my patch on and see what crashes?

[Sonicadvance1]

This time found in MGRR. It flips the problem space on its head.
Sorry @pmatos that I keep finding bugs and poking holes in your implementation.

Lovely. I will take a look. Thanks. How are you finding these? I assume MGRR is metal gear. Are you running games with my patch on and see what crashes?

Yea, anything that can potentially cause problems I tend to run through a suite of games and ensure behaviour doesn't change. So I merge/build your patch and try a bunch of random games. Also yea, MGRR = Metal Gear Rising Revengeance

[pmatos]

Thanks for the reply.
Looking on the bright side - at least we are extending SignExtendBug.asm nicely. :)

LGTM.