Merge pull request #3546 from alyssarosenzweig/flag/cleanup

Minor cleanups around flags
FEX-Emu · Apr 2, 2024 · 37f2b41 · 37f2b41
2 parents bd0b5ec + 0a7b3ef
commit 37f2b41
Show file tree

Hide file tree

Showing 5 changed files with 125 additions and 131 deletions.
diff --git a/FEXCore/Source/Interface/Core/OpcodeDispatcher.h b/FEXCore/Source/Interface/Core/OpcodeDispatcher.h
@@ -1304,13 +1304,9 @@ friend class FEXCore::IR::PassManager;
   }
 
   OrderedNode *GetNZCV() {
-    if (!CachedNZCV) {
+    if (!CachedNZCV)
       CachedNZCV = _LoadNZCV();
 
-      // We don't know what's set
-      PossiblySetNZCVBits = ~0;
-    }
-
     return CachedNZCV;
   }
 
@@ -1337,10 +1333,8 @@ friend class FEXCore::IR::PassManager;
   }
 
   void SetNZ_ZeroCV(unsigned SrcSize, OrderedNode *Res) {
+    HandleNZ00Write();
     _TestNZ(IR::SizeToOpSize(SrcSize), Res, Res);
-    CachedNZCV = _LoadNZCV();
-    PossiblySetNZCVBits = (1u << 31) | (1u << 30);
-    NZCVDirty = false;
   }
 
   void InsertNZCV(unsigned BitOffset, OrderedNode *Value, signed FlagOffset, bool MustMask) {