Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify notification service #3087

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #3087 (4b45968) into develop (7e1f13d) will increase coverage by 0.00%.
The diff coverage is 29.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3087   +/-   ##
==========================================
  Coverage      59.07%   59.08%           
+ Complexity      4422     4409   -13     
==========================================
  Files            560      562    +2     
  Lines          20187    20151   -36     
  Branches        1021     1013    -8     
==========================================
- Hits           11926    11906   -20     
+ Misses          7721     7707   -14     
+ Partials         540      538    -2     
Files Coverage Δ
...forever/client/chat/AbstractChatTabController.java 71.75% <ø> (ø)
...java/com/faforever/client/coop/CoopController.java 58.62% <100.00%> (ø)
...java/com/faforever/client/fa/GameFullNotifier.java 87.50% <ø> (ø)
...orever/client/fx/contextmenu/AbstractMenuItem.java 100.00% <ø> (ø)
...ava/com/faforever/client/game/GamePathHandler.java 35.18% <100.00%> (+0.63%) ⬆️
...va/com/faforever/client/game/VaultPathHandler.java 66.66% <100.00%> (+1.96%) ⬆️
...ver/client/notification/ImmediateNotification.java 55.55% <100.00%> (-17.78%) ⬇️
...er/client/notification/PersistentNotification.java 75.00% <100.00%> (-25.00%) ⬇️
...va/com/faforever/client/notification/Severity.java 100.00% <ø> (ø)
...ver/client/notification/TransientNotification.java 83.33% <100.00%> (+23.33%) ⬆️
... and 39 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1f13d...4b45968. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 175b61b into develop Dec 17, 2023
3 of 5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/notification-simplification branch December 17, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant