Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to java 21 #3064

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Upgrade to java 21 #3064

merged 7 commits into from
Dec 1, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #3064 (bece543) into develop (7e39b73) will decrease coverage by 0.16%.
Report is 2 commits behind head on develop.
The diff coverage is 62.51%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3064      +/-   ##
=============================================
- Coverage      58.88%   58.72%   -0.16%     
+ Complexity      4461     4460       -1     
=============================================
  Files            558      560       +2     
  Lines          20201    20451     +250     
  Branches        1035     1035              
=============================================
+ Hits           11895    12010     +115     
- Misses          7757     7896     +139     
+ Partials         549      545       -4     
Files Coverage Δ
...client/achievements/AchievementItemController.java 100.00% <ø> (ø)
.../main/java/com/faforever/client/api/IceServer.java 100.00% <100.00%> (ø)
.../java/com/faforever/client/audio/AudioService.java 100.00% <100.00%> (ø)
...ava/com/faforever/client/avatar/AvatarService.java 100.00% <100.00%> (+18.18%) ⬆️
...orever/client/chat/ChatCategoryItemController.java 65.51% <100.00%> (-0.59%) ⬇️
...ava/com/faforever/client/chat/ChatChannelUser.java 93.93% <100.00%> (+4.75%) ⬆️
...om/faforever/client/chat/TrustEveryoneFactory.java 25.00% <ø> (ø)
...r/client/chat/UserListCustomizationController.java 100.00% <ø> (ø)
...ever/client/chat/emoticons/EmoticonController.java 100.00% <ø> (ø)
...lient/chat/emoticons/EmoticonsGroupController.java 100.00% <ø> (ø)
... and 193 more

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b6ef4...bece543. Read the comment docs.

@Sheikah45 Sheikah45 force-pushed the maintenance/java-21 branch from a9ec380 to bece543 Compare December 1, 2023 17:11
@Sheikah45 Sheikah45 merged commit b21ceb6 into develop Dec 1, 2023
@Sheikah45 Sheikah45 deleted the maintenance/java-21 branch December 1, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant