Removed the use priority settings #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3062 +/- ##
=============================================
+ Coverage 58.78% 58.81% +0.02%
Complexity 4459 4459
=============================================
Files 560 560
Lines 20401 20391 -10
Branches 1028 1027 -1
=============================================
Hits 11993 11993
+ Misses 7862 7854 -8
+ Partials 546 544 -2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sheikah45
reviewed
Nov 30, 2023
Comment on lines
-189
to
175
|
|
||
| public BooleanProperty changeProcessPriorityProperty() { | ||
| return changeProcessPriority; | ||
| } | ||
| } |
There was a problem hiding this comment.
The getter and setter and whole field should be removed
|
The builds are failing when you remove the fields you also have to fix wherever they are used |
Sheikah45
approved these changes
Dec 2, 2023
Sheikah45
force-pushed
the
bug/#3057-remove-useHighPriority-option
branch
from
8414c37 to
8277852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3057