SSR: move handling for Redirect Campaigns #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks if we use searching and rendering separated in our customization
Rayn93
approved these changes
Jun 11, 2024
|
Thank you @SvenHerrmann for this improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in searching so it also works if we use searching and rendering separated in our customization
In this PR
#169
we separated searching and rendering in 2 methods.
We use these 2 methods in our customizations (instead of just "getContent")
This PR
#187
this separation is ignored.
I moved this functionality into one of the separated methods, so it works for "getContent" as well as "searchResults"+"renderResults".
Please note that the source and target branch must be
master(details).