Merge pull request #1141 from zancas/2.3-stable

Members modify() broken when setting session attribute

f5/__init__.py

@@ -12,4 +12,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__version__ = '2.3.2'
+__version__ = '2.3.3'

f5/bigip/tm/ltm/pool.py

@@ -177,7 +177,7 @@ def _modify(self, **patch):
                       "'user-down'" % patch['state']
                 raise MemberStateModifyUnsupported(msg)
         if 'session' in patch:
-            if patch['session'] != 'user-enabled' and patch['state'] != \
+            if patch['session'] != 'user-enabled' and patch['session'] != \
                     'user-disabled':
                 msg = "The members resource does not support a modify with " \
                       "the value of the 'session' attribute as %s. " \

f5/bigip/tm/ltm/test/functional/test_pool.py

@@ -219,6 +219,16 @@ def test_update_session_state_kwargs(self, request, bigip):
         m2.session = m1.session
         m2.state = m1.state
 
+    def test_session_modify(self, request, bigip):
+        m1, pool = setup_member_test(request, bigip, 'membertestpool1',
+                                     'Common')
+        assert m1.session == 'user-enabled'
+        m1.modify(session='user-disabled')
+        m2 = pool.members_s.members.load(
+            name='192.168.15.15:80', partition='Common')
+        assert m2.session == 'user-disabled'
+        assert m1.session == m2.session
+
     def test_state_modify(self, request, bigip):
         m1, pool = setup_member_test(request, bigip, 'membertestpool1',
                                      'Common')